Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start flush queue worker after wal replay #2456

Merged
merged 2 commits into from
May 13, 2023
Merged

Start flush queue worker after wal replay #2456

merged 2 commits into from
May 13, 2023

Conversation

ie-pham
Copy link
Contributor

@ie-pham ie-pham commented May 10, 2023

What this PR does: Move the flush queue worker to start after wal replay and block rediscovery.

Which issue(s) this PR fixes:
Address https:/grafana/tempo-squad/issues/223
Fixes https:/grafana/tempo-squad/issues/242

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@ie-pham ie-pham changed the title moved flush queue Start flush queue worker after wal replay May 10, 2023
Copy link
Member

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed: I'm good on this whenever you want to merge it, but do test it in a few different live environments first.

@ie-pham ie-pham marked this pull request as ready for review May 12, 2023 18:40
@ie-pham ie-pham merged commit dcf8a2a into grafana:main May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants